chore: add tsd tests for typings #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new Ci task to check that the typings are as expected. It uses `tsd` (as done on `vue-next`), and adds a basic test in `test-dts`for the wrapper inference.
cexbrayat
force-pushed
the
chore/dts-tests
branch
from
12c2c0f
to
26a8fee
Compare
This was referenced Apr 17, 2020
Merged
|
Great! Should I merge this or are you going to make more PRs targeting this? |
|
Oops, I get it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new Ci task to check that the typings are as expected. It uses
tsd(as done onvue-next), and adds a basic test intest-dtsfor the wrapper inference.Note that I had to to @types/node to avoid an issue I fixed in Vue itself vuejs/core#968
This is a base PR for a follow-up that will improve the typings of
mountandpropsoptions as @lmiller1990 suggested