Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deduplicate change detection caveat sections #2497

Merged
merged 2 commits into from
Feb 26, 2020

Conversation

sarahdayan
Copy link
Contributor

This deduplicates the object change detection caveats sub-section that was on the Reactivity in Depth and List Rendering sections.

For consistency, it also moved the array change detection caveats sub-section from List Rendering sections to Reactivity in Depth, so all caveats are in a single place.

fixes #2352

Copy link
Member

@phanan phanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I have only two super minor comments inlined.

src/v2/guide/reactivity.md Outdated Show resolved Hide resolved
src/v2/guide/reactivity.md Outdated Show resolved Hide resolved
@sarahdayan
Copy link
Contributor Author

🎉 🚀

@phanan phanan merged commit 17ab220 into vuejs:master Feb 26, 2020
@phanan
Copy link
Member

phanan commented Feb 26, 2020

Thanks @sarahdayan!

@sarahdayan sarahdayan deleted the fix/caveats-duplication branch February 26, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated reactivity explanations
2 participants