-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when optional camel-cased props are missing #2342
Conversation
8b60dcd
to
b61c1fa
Compare
@@ -8,7 +8,8 @@ export default Vue.extend({ | |||
callback: { | |||
type: Function as PropType<() => void> | |||
}, | |||
arr: Array as PropType<string[]> | |||
arr: Array as PropType<string[]>, | |||
darkMode: { type: Boolean, default: false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we adding this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If add this camelCase props, it success fixed when no errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just call it camelCase
so it's clear what you are testing against
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Awesome work 👏 |
Fixed #2314