Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont include used attributes in suggestions #2565

Merged

Conversation

sapphi-red
Copy link
Contributor

This PR removes used attributes from suggestions except

@sapphi-red sapphi-red force-pushed the remove-used-attributes-from-suggestion branch from 3f63973 to 552187a Compare December 14, 2020 10:45
server/src/modes/template/services/htmlCompletion.ts Outdated Show resolved Hide resolved
server/src/modes/template/services/htmlCompletion.ts Outdated Show resolved Hide resolved
.prettierignore Show resolved Hide resolved
@sapphi-red sapphi-red force-pushed the remove-used-attributes-from-suggestion branch from e9662b9 to 1680b26 Compare December 14, 2020 14:23
@sapphi-red
Copy link
Contributor Author

I rewrote it with Set. I have forgotten about the previous comment... #2565 (comment)

@yoyo930021 yoyo930021 merged commit 690c988 into vuejs:master Jan 21, 2021
@sapphi-red sapphi-red deleted the remove-used-attributes-from-suggestion branch January 21, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants