Skip to content

Commit 59e1201

Browse files
author
Guillaume Chau
committed
fix(dependencies): better metadata load error handling
1 parent d11290a commit 59e1201

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

packages/@vue/cli-ui/apollo-server/connectors/dependencies.js

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ const path = require('path')
33
const LRU = require('lru-cache')
44
const semver = require('semver')
55
const execa = require('execa')
6+
const chalk = require('chalk')
67
// Connectors
78
const cwd = require('./cwd')
89
const folders = require('./folders')
@@ -22,6 +23,7 @@ const {
2223
const { getCommand } = require('../util/command')
2324
const { resolveModuleRoot } = require('../util/resolve-path')
2425
const { notify } = require('../util/notification')
26+
const { log } = require('../util/logger')
2527

2628
const PROGRESS_ID = 'dependency-installation'
2729
const CLI_SERVICE = '@vue/cli-service'
@@ -106,20 +108,25 @@ async function getMetadata (id, context) {
106108
metadata = JSON.parse(stdout).data
107109
} catch (e) {
108110
// yarn info failed
109-
console.log(e)
110111
}
111112
}
112113

113114
if (!metadata) {
114-
const res = await getPackageVersion(id)
115-
if (res.statusCode === 200) {
116-
metadata = res.body
115+
try {
116+
const res = await getPackageVersion(id)
117+
if (res.statusCode === 200) {
118+
metadata = res.body
119+
}
120+
} catch (e) {
121+
// No connection?
117122
}
118123
}
119124

120125
if (metadata) {
121126
metadataCache.set(id, metadata)
122127
return metadata
128+
} else {
129+
log('Dpendencies', chalk.yellow(`Can't load metadata`), id)
123130
}
124131
}
125132

0 commit comments

Comments
 (0)