Skip to content

Commit d442de2

Browse files
author
Guillaume Chau
committed
fix(task parameters): revert to a modal
1 parent 4feddbd commit d442de2

File tree

1 file changed

+36
-37
lines changed

1 file changed

+36
-37
lines changed

packages/@vue/cli-ui/src/views/ProjectTaskDetails.vue

Lines changed: 36 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
data-testid="run-task"
1717
@click="runTask()"
1818
/>
19+
1920
<VueButton
2021
v-else
2122
icon-left="stop"
@@ -25,43 +26,14 @@
2526
@click="stopTask()"
2627
/>
2728

28-
<VueDropdown
29-
v-if="task.prompts.length"
30-
placement="bottom"
31-
>
32-
<VueButton
33-
slot="trigger"
34-
icon-left="settings"
35-
class="icon-button primary"
36-
:disabled="task.status === 'running'"
37-
v-tooltip="$t('org.vue.views.project-task-details.parameters')"
38-
@click="showParameters = true"
39-
/>
40-
41-
<div class="task-settings">
42-
<div class="pane-toolbar">
43-
<VueIcon icon="settings"/>
44-
<div class="title">{{ $t('org.vue.views.project-task-details.parameters') }}</div>
45-
<VueButton
46-
class="icon-button flat"
47-
icon-left="close"
48-
v-tooltip="$t('org.vue.views.project-task-details.actions.close')"
49-
v-close-popover
50-
/>
51-
</div>
52-
53-
<PromptsList
54-
:prompts="visiblePrompts"
55-
class="prompts"
56-
@answer="answerPrompt"
57-
/>
58-
59-
<div class="vue-ui-text info banner">
60-
<VueIcon icon="info" class="big"/>
61-
<span>{{ $t('org.vue.views.project-task-details.parameters-info') }}</span>
62-
</div>
63-
</div>
64-
</VueDropdown>
29+
<VueButton
30+
slot="trigger"
31+
icon-left="settings"
32+
class="icon-button primary"
33+
:disabled="task.status === 'running'"
34+
v-tooltip="$t('org.vue.views.project-task-details.parameters')"
35+
@click="showParameters = true"
36+
/>
6537

6638
<div
6739
class="command"
@@ -131,6 +103,33 @@
131103
/>
132104
</div>
133105
</template>
106+
107+
<VueModal
108+
v-if="showParameters"
109+
:title="$t('org.vue.views.project-task-details.parameters')"
110+
class="medium anchor"
111+
@close="showParameters = false"
112+
>
113+
<div class="default-body">
114+
<PromptsList
115+
:prompts="visiblePrompts"
116+
@answer="answerPrompt"
117+
/>
118+
119+
<div class="vue-ui-text info banner">
120+
<VueIcon icon="info" class="big"/>
121+
<span>{{ $t('org.vue.views.project-task-details.parameters-info') }}</span>
122+
</div>
123+
</div>
124+
125+
<div slot="footer" class="actions">
126+
<VueButton
127+
class="primary big"
128+
:label="$t('org.vue.views.project-task-details.actions.close')"
129+
@click="showParameters = false"
130+
/>
131+
</div>
132+
</VueModal>
134133
</div>
135134
</template>
136135

0 commit comments

Comments
 (0)