feat(xdg-compliance): rc file location hierarchy #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyx990803
requested changes
May 21, 2018
packages/@vue/cli/lib/options.js
Outdated
| } | ||
|
|
||
| // XDG defined backup folder if XDG_CONFIG_HOME is undefined | ||
| xdgConfigHome = path.join(os.homedir(), '.config') |
There was a problem hiding this comment.
This would be a breaking change. We should only change behavior when XDG_CONFIG_HOME is explicitly present.
There was a problem hiding this comment.
I'll make the change later today. Thanks
`vue-cli` now uses the following hierarchy for hosting its rc file: * `VUE_CLI_CONFIG_PATH * `XDG_CONFIG_HOME/vue/.vuerc` * `HOME/.config/vue/.vuerc` * `HOME/.vuerc` closes #1325
|
Should be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vue-clinow uses the following hierarchy for hosting its rc file:VUE_CLI_CONFIG_PATHXDG_CONFIG_HOME/vue/.vuercHOME/.config/vue/.vuercHOME/.vuercLet me know if you need something changed
I would like to point out that the middle 2 paths probably shouldn't be hidden files. Left that up to the devs though.
closes #1325