Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel-preset-app): multiPage repo add option entryFileList #3470

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

WilsonLiu95
Copy link
Contributor

To inject polyfills to all entry file.
Multi page repo now will be only inject polyfills to the first entry file.And the queue of entry file list may be different.So the hash may change in different machine.
We should inject polyfills to all entry file.

@haoqunjiang
Copy link
Member

haoqunjiang commented Feb 27, 2019

Thank you so much for this pull request!
So I finally figured out what caused this issue: #2983

Actually, due to the presence of thread-loader it is not possible to reliably determine the real entry file. I think we can just remove the entryFile logic and only rely on the entryFileList option, and then automatically set this field in @vue/cli-plugin-babel so that users don't need to be aware of this change (this can be done in a separate pull request though).

@WilsonLiu95
Copy link
Contributor Author

WilsonLiu95 commented Feb 28, 2019

yes, due to the presence of thread-loader and cache-loader.When JS file is cache then the first file will be change.

I have change the name to entryFiles.

@haoqunjiang haoqunjiang merged commit 7df0c58 into vuejs:dev Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants