Skip to content

fix setting env by -e in e2e tests #3583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2019
Merged

fix setting env by -e in e2e tests #3583

merged 1 commit into from
Mar 6, 2019

Conversation

doits
Copy link
Contributor

@doits doits commented Mar 6, 2019 •
edited
Loading

Before it was only checking for --env. So if -e something was used, the generated command line included -e and --env:

... -e something ... --env chrome

Now it does not append --env chrome if -e is used.

@haoqunjiang haoqunjiang merged commit 9aff29d into vuejs:dev Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doits @haoqunjiang