Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: make vuex a separate plugin #4242

Merged
merged 1 commit into from Jul 6, 2019

Conversation

Projects
None yet
4 participants
@pksunkara
Copy link
Collaborator

commented Jul 5, 2019

Fixes #2335, #4024

@pksunkara

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 6, 2019

Addressed review comments and force pushed the commit.

@sodatea

sodatea approved these changes Jul 6, 2019

@sodatea sodatea merged commit 362587a into vuejs:dev Jul 6, 2019

7 checks passed

ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@vue-bot

This comment has been minimized.

Copy link

commented Jul 6, 2019

Hey @pksunkara, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@pksunkara pksunkara deleted the pksunkara:vuex branch Jul 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.