fix: work around npm6/postcss8 hoisting issue #6358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
reviewed
Mar 17, 2021
haoqunjiang
changed the title
merceyz
reviewed
Mar 18, 2021
| @@ -0,0 +1,8 @@ | |||
| // this file will be renamed to hotfix.js if the package is installed by npm 6 | |||
| module.exports = (api) => { | |||
| api.extendPackage({ | |||
There was a problem hiding this comment.
You can check the package manager version here and avoid the postinstall
There was a problem hiding this comment.
The generator is controlled by @vue/cli itself, so npm is not involved during the execution, therefore the package manager version is not available.
I don't feel like adding an ad hoc API just for this fix, so I chose to keep the postinstall script.
haoqunjiang
changed the title
|
Oh I shouldn't have merged this one… I may better throw a runtime error for incorrect hoisting results. |
haoqunjiang
added a commit
that referenced
this pull request
Mar 24, 2021
This reverts commit 27b4263.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6342
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: