Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli-service): wrong property name (typo) #6645

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Conversation

Vinsea
Copy link
Contributor

@Vinsea Vinsea commented Aug 20, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

the value of isModuleBuild is false here, so you can write anything for the property, but it's better to write it correctly.

config
    .plugin('modern-mode-legacy')
    .use(ModernModePlugin, [{
      targetDir,
      TYPO_PROP: false
    }])

class ModernModePlugin {
  constructor ({ targetDir, isModuleBuild }) {
    this.targetDir = targetDir
    this.isModuleBuild = isModuleBuild
  }
  // ...
}

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thank you!

@haoqunjiang haoqunjiang merged commit 0f09454 into vuejs:dev Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants