SharedData: classifyComponent, openInEditorHost #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akryum
changed the title
|
Here is the doc for Customize requestYou can change the request host (default // App served from port 4000
// Webpack dev server on port 9000
Vue.config.devtoolsConfig = {
openInEditorHost: 'http://localhost:9000/'
} |
|
This may need Vue typings update. |
|
@evan Changed to |
mathieutu
added a commit
to mathieutu/laravel-mix-editor
that referenced
this pull request
Jan 30, 2018
…nents come from. (should work after merging vuejs/devtools-v6#575)
michalsnik
approved these changes
Mar 11, 2018
| // Load persisted fields | ||
| if (persist) { | ||
| persist.forEach(key => { | ||
| const value = storage.get(`shared-data:${key}`) |
There was a problem hiding this comment.
Perhaps we should use less generic storage key? Additional vue related prefix would rather be enough :)
There was a problem hiding this comment.
This is done on the devtools side, and thus the localStorage is already specific to the extension.
|
What's the timeline on this? Would be pretty useful for anyone using Webpacker to mount a Vue app in their Rails application. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
SharedDatasystem that automatically synchronize data between the devtools and the backend, with persisting capabilities. Data is reactive in Vue apps.Currently holds:
classifyComponents(persisted), used by both the devtools component and the backend component highlighteropenInEditorHostthat can be set by the backend code (fix Open in editor not working when not served by node. #598)