Skip to content

Commit

Permalink
fix: pass correct args to RuleSet.normalizeRule (fix #1210)
Browse files Browse the repository at this point in the history
  • Loading branch information
yyx990803 committed Mar 23, 2018
1 parent b860b24 commit 1c54dc4
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ module.exports = class VueLoaderPlugin {
// #1201 we need to skip the `include` check when locating the vue rule
const clone = Object.assign({}, rule)
delete clone.include
const normalized = RuleSet.normalizeRule(clone)
const normalized = RuleSet.normalizeRule(clone, {}, '')
return !rule.enforce && normalized.resource && normalized.resource(`foo.vue`)
})
const vueRule = rawRules[vueRuleIndex]
Expand Down
23 changes: 21 additions & 2 deletions test/edgeCases.spec.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const {
bundle,
mockRender,
mockBundleAndRun
} = require('./utils')
Expand Down Expand Up @@ -58,7 +59,7 @@ test('test-less oneOf rules', done => {
})

test('babel-loader inline options', done => {
mockBundleAndRun({
bundle({
entry: 'basic.vue',
module: {
rules: [
Expand All @@ -74,5 +75,23 @@ test('babel-loader inline options', done => {
}
]
}
}, res => assertComponent(res, done))
}, () => done(), true)
})

// #1210
test('normalize multiple use + options', done => {
bundle({
entry: 'basic.vue',
modify: config => {
config.module.rules[0] = {
test: /\.vue$/,
use: [
{
loader: 'vue-loader',
options: {}
}
]
}
}
}, () => done(), true)
})

0 comments on commit 1c54dc4

Please sign in to comment.