Skip to content

Commit

Permalink
fix: avoid babel options validation error (fix #1209)
Browse files Browse the repository at this point in the history
  • Loading branch information
yyx990803 committed Mar 23, 2018
1 parent 8d93672 commit d3e3f5e
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 1 deletion.
9 changes: 8 additions & 1 deletion lib/plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,15 @@ function cloneRule (rule, normalizedRule) {
return res
}

// Some loaders like babel-loader passes its own option directly to babel
// and since babel validates the options, "ident" would cause an unknown option
// error. For these loaders we'll bail out on the ident reuse.
const reuseIdentBlackList = /babel-loader/

// Reuse options ident, so that imports from within css-loader would get the
// exact same request prefixes, avoiding duplicated modules (#1199)
function reuseIdent (use) {
if (use.ident) {
if (use.ident && !reuseIdentBlackList.test(use.loader)) {
use.options.ident = use.ident
delete use.ident
}
Expand Down
20 changes: 20 additions & 0 deletions test/edgeCases.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,23 @@ test('test-less oneOf rules', done => {
}
}, res => assertComponent(res, done))
})

test('babel-loader inline options', done => {
mockBundleAndRun({
entry: 'basic.vue',
module: {
rules: [
{
test: /\.js/,
loader: 'babel-loader',
options: {
babelrc: false,
presets: [
[require('babel-preset-env'), { modules: false }]
]
}
}
]
}
}, res => assertComponent(res, done))
})

0 comments on commit d3e3f5e

Please sign in to comment.