Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(loader): support options.productionMode #1208

Merged
merged 3 commits into from
Mar 23, 2018
Merged

Conversation

pi0
Copy link

@pi0 pi0 commented Mar 23, 2018

With webpack 4, this.minimize value is undefined. This PR allows enabling minimize with loader options.


A side note from here:

Guideline: Loaders should receive all options via this.query. They should not use other ways to receive options, i. e. no property in webpack options, no environment variable.

pi0 pushed a commit to nuxt/nuxt that referenced this pull request Mar 23, 2018
@yyx990803
Copy link
Member

I don't think the option should be called minimize since vue-loader itself doesn't perform any minification. productionMode is more explicit.

@pi0
Copy link
Author

pi0 commented Mar 23, 2018

@yyx990803 done :)

@pi0 pi0 changed the title fix(loader): use options.minimize feat(loader): support options.productionMode Mar 23, 2018
@yyx990803 yyx990803 merged commit 69bc1c1 into vuejs:next Mar 23, 2018
@pi0 pi0 deleted the patch-1 branch March 23, 2018 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants