fix: merge custom queries rather than appending #1911
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we simply append any existing
resourceQuery
to the end of any generated query string. In the event of a custom query being passed this leads to an invalid query, such as:The four locations where this happens are:
vue-loader/src/index.ts
Line 159 in 6dce21e
vue-loader/src/index.ts
Line 179 in 6dce21e
vue-loader/src/index.ts
Line 199 in 6dce21e
vue-loader/src/index.ts
Line 271 in 6dce21e
I realise this is a bit of an edge case, but as long as we are appending
resourceQuery
to the end of a query string we should probably normalise it.