pass query.id as an option to addId in style-rewriter #237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global variables (
currentId
) should not be used for passing arguments to "execute-later" async functions.This patch fixes a hard-to-reproduce bug, which is described below.
For example, I have two vue component
foo.vue
andbar.vue
and they both have the same content as below:When I use them like this:
It produces HTML as following
This is correct. But on the style side, you get the following with some setup
and the following with some other setup
The expected style is
You won't reproduce the bug by replaying what I said above. It's only a simplified description of what I've observed from our quite big codebase with complex dependencies. But you can reason about it.