Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router-view): add condition to see whether the tree is inactive (fix #2552) #2592

Merged
merged 2 commits into from
Apr 15, 2019
Merged

fix(router-view): add condition to see whether the tree is inactive (fix #2552) #2592

merged 2 commits into from
Apr 15, 2019

Conversation

zrh122
Copy link
Contributor

@zrh122 zrh122 commented Jan 22, 2019

close #2552

@posva
Copy link
Member

posva commented Jan 22, 2019

Thanks! Could you add a test case for this? e2e should be easier for the moment for this one

@zrh122
Copy link
Contributor Author

zrh122 commented Jan 22, 2019

Thanks! Could you add a test case for this? e2e should be easier for the moment for this one

Yes, i will

@zrh122
Copy link
Contributor Author

zrh122 commented Jan 23, 2019

@posva , e2e test added.

posva
posva approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will do some minor modifications locally

@posva posva merged commit e6d8fd2 into vuejs:dev Apr 15, 2019
This was referenced Aug 29, 2019
Open
Open
Closed
Open
@tt9133github tt9133github mentioned this pull request Sep 18, 2019
Open
This was referenced Sep 22, 2019
Merged
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 1, 2019
Open
This was referenced Oct 26, 2019
Open
Open
This was referenced Jan 20, 2020
Merged
Merged
Merged
Merged
This was referenced Feb 5, 2020
Merged
Open
Merged
@tt9133github tt9133github mentioned this pull request Feb 14, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
This was referenced Mar 4, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 24, 2020
Merged
This was referenced Mar 28, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nested router-view renders incorrect component with wrapping keep-alive at root
2 participants
@zrh122 @posva