fix: correctly calculate path when pathMatch is empty string (fix #3106)
#3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
requested changes
Jan 29, 2020
src/util/params.js
Outdated
| @@ -20,7 +20,8 @@ export function fillParams ( | |||
| (regexpCompileCache[path] = Regexp.compile(path)) | |||
|
|
|||
| // Fix #2505 resolving asterisk routes { name: 'not-found', params: { pathMatch: '/not-found' }} | |||
| if (params.pathMatch) params[0] = params.pathMatch | |||
| // `params.pathMatch === ''` fixes #3106 so that you can work with location descriptor object having params.pathMatch equal to empty string | |||
| if (params.pathMatch || params.pathMatch === '') params[0] = params.pathMatch | |||
There was a problem hiding this comment.
let's just check if it's a string with a typeof operator
This was referenced Mar 14, 2020
This was referenced Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.