Skip to content

fix: support async components in stubs #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2018
Merged

fix: support async components in stubs #1039

merged 3 commits into from
Nov 25, 2018

Conversation

eddyerburgh
Copy link
Member

  • Handle asnyc component stubs

Fixes #1026

jacekkarczmarczyk
jacekkarczmarczyk reviewed Nov 25, 2018
View reviewed changes
test/specs/mounting-options/stubs.spec.js Outdated
expect(HTML).to.contain('span')
expect(HTML).to.contain(
mountingMethod.name === 'renderToString'
? 'DymaicHello2-stub'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 😅

@eddyerburgh eddyerburgh merged commit 6a4e19d into dev Nov 25, 2018
@eddyerburgh eddyerburgh deleted the support-async-stubs branch November 25, 2018 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jacekkarczmarczyk jacekkarczmarczyk jacekkarczmarczyk left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyerburgh @jacekkarczmarczyk