Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document about nextTick difference between English and Chinese #1451

Closed
zkd8907 opened this issue Feb 26, 2020 · 8 comments
Closed

Document about nextTick difference between English and Chinese #1451

zkd8907 opened this issue Feb 26, 2020 · 8 comments

Comments

@zkd8907
Copy link
Contributor

zkd8907 commented Feb 26, 2020

Version

1.0.0-beta.31

Reproduction link

https://jsbin.com/pokuluhado/edit?html,js

Steps to reproduce

In Chinese version, it says there is no need to use Vue.nextTick() because Vue Test Utils has applied it. But in English Version, it says We need to use Vue.nextTick() to wait until Vue has performed the DOM update after we set a reactive property.
My question is, which one is correct? After my testing, I found that if I changed the data of component without using Vue.nextTick(), wrapper.html() is still the original value.

What is expected?

As Chinese Version, there is no need to use Vue.nextTick().

What is actually happening?

Test failed.

@lmiller1990
Copy link
Member

You need to use nextTick, sync mode was removed a few versions ago. The translations are mostly out of date - this is a hard problem, I don't have a good way to keep them updated.

If you want to make a PR that would be much appreciated. The English docs are the "source of truth".

@zkd8907
Copy link
Contributor Author

zkd8907 commented Feb 27, 2020

Thank you your reply.
I've tried to translate this part from English to Chinese again, and I will make a PR later. Besides, I noticed that there also are differences translation about nextTick in other parts, and may need to be re-translated.

@lmiller1990
Copy link
Member

Yep. We need a way to track changes and either notify a dedicated translator or just flag in the docs something like "this translation could be out of date". Not sure of any tools that do this, though.

@zkd8907
Copy link
Contributor Author

zkd8907 commented Mar 18, 2020

Yep. We need a way to track changes and either notify a dedicated translator or just flag in the docs something like "this translation could be out of date". Not sure of any tools that do this, though.

lmiller, I updated the Chinese translation of the nextTick part of the document, and added some new sections in common-tips.md. I have no better idea about the multilingual translation. However, I will update Chinese version in my spare time later.

@lmiller1990
Copy link
Member

Thanks, just need you to run the yarn format:check && yarn lint (see PR review)

@zkd8907
Copy link
Contributor Author

zkd8907 commented Mar 18, 2020

I've re-committed after format :)

lmiller1990 pushed a commit that referenced this issue Mar 18, 2020
@lmiller1990
Copy link
Member

nice job, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants