Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: keep update #674

Merged
merged 2 commits into from
Jun 6, 2018
Merged

docs: keep update #674

merged 2 commits into from
Jun 6, 2018

Conversation

Jinjiang
Copy link
Member

@Jinjiang Jinjiang commented Jun 1, 2018

Thanks.

@38elements
Copy link
Contributor

38elements commented Jun 1, 2018

Hi, @Jinjiang.

IMHO,
Since the links in find.md and findAll.md transfer top of page,
I think it is better not to remove them.

@38elements
Copy link
Contributor

Transitioning from the right side index, it displays separate page.

https://vue-test-utils.vuejs.org/

https://vue-test-utils.vuejs.org/api/wrapper/find.html

@Jinjiang
Copy link
Member Author

Jinjiang commented Jun 5, 2018

Sorry for late. 😅

Transitioning from the right side index, it displays separate page.
https://vue-test-utils.vuejs.org/
https://vue-test-utils.vuejs.org/api/wrapper/find.html

Yes, I also find it. I am a little confused about offering https://vue-test-utils.vuejs.org/api/wrapper/#find-selector and https://vue-test-utils.vuejs.org/api/wrapper/find.html at the same time. I guess the second one is not on purpose since no other link can go there and the relative URLs of links there goes wrong @eddyerburgh 🤔

@Jinjiang
Copy link
Member Author

Jinjiang commented Jun 5, 2018

IMHO,
Since the links in find.md and findAll.md transfer top of page,
I think it is better not to remove them.

And that's another thing confused for me because not every API headings has a link to top. Only find() and findAll() have them. So I removed them.
Or we add link to top for every API headings but it's not necessary imo.

Thanks :-)

@eddyerburgh
Copy link
Member

Yeah I think we can still work on the layout. I wanted to include the name of the arguments, but the URL is autogenerated. If either of you have suggestions for improving the docs I'm open to suggestions!

@38elements
Copy link
Contributor

38elements commented Jun 5, 2018

IMHO,
Since the links in find.md and findAll.md transfer top of page,
I think it is better not to remove them.

Thank you for reply.
The top of page is Wrapper section.
I think it is appropriate to transfer to Wrapper section by clicking Wrapper link.

https://vue-test-utils.vuejs.org/api/wrapper/#properties

@38elements
Copy link
Contributor

@Jinjiang
I am sorry.
I changed my opinion.
I think that it is not important that removing or not links in find.md and findAll.md.
I think that you will maintain this document longer than me.
I think that your opinion should be respected.

Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄

@eddyerburgh eddyerburgh merged commit 0437e26 into vuejs:dev Jun 6, 2018
@Jinjiang Jinjiang deleted the docs branch June 6, 2018 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants