fix(ssr): handle v-text/v-html with non-string value

fix #6572
vuejs · Sep 13, 2017 · 09106f0 · 09106f0
1 parent 7116af4
commit 09106f0
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/src/server/optimizing-compiler/codegen.js b/src/server/optimizing-compiler/codegen.js
@@ -200,10 +200,10 @@ function elementToOpenTagSegments (el, state): Array<StringSegment> {
 function childrenToSegments (el, state): Array<StringSegment> {
   let binding
   if ((binding = el.attrsMap['v-html'])) {
-    return [{ type: EXPRESSION, value: binding }]
+    return [{ type: EXPRESSION, value: `_s(${binding})` }]
   }
   if ((binding = el.attrsMap['v-text'])) {
-    return [{ type: INTERPOLATION, value: binding }]
+    return [{ type: INTERPOLATION, value: `_s(${binding})` }]
   }
   return el.children
     ? nodesToSegments(el.children, state)

diff --git a/test/ssr/ssr-string.spec.js b/test/ssr/ssr-string.spec.js
@@ -374,6 +374,18 @@ describe('SSR: renderToString', () => {
     })
   })
 
+  it('v-html with null value', done => {
+    renderVmWithOptions({
+      template: '<div><div v-html="text"></div></div>',
+      data: {
+        text: null
+      }
+    }, result => {
+      expect(result).toContain('<div data-server-rendered="true"><div></div></div>')
+      done()
+    })
+  })
+
   it('v-text', done => {
     renderVmWithOptions({
       template: '<div><div v-text="text"></div></div>',
@@ -386,6 +398,18 @@ describe('SSR: renderToString', () => {
     })
   })
 
+  it('v-text with null value', done => {
+    renderVmWithOptions({
+      template: '<div><div v-text="text"></div></div>',
+      data: {
+        text: null
+      }
+    }, result => {
+      expect(result).toContain('<div data-server-rendered="true"><div></div></div>')
+      done()
+    })
+  })
+
   it('child component (hoc)', done => {
     renderVmWithOptions({
       template: '<child class="foo" :msg="msg"></child>',