Skip to content

feat(ssr): wait for context.rendered (fix #11256) #11266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

eunjae-lee
Copy link

@eunjae-lee eunjae-lee commented Mar 31, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This PR fixes #11256.
What this PR does is basically wait for context.rendered(context) function call if it returns a Promise.
If rendered can be asynchronous, SSR can become more flexible and powerful.
I wrote all the details in #11256.

@eunjae-lee eunjae-lee changed the title feat(ssr): wait for context.rendered (close #11256) feat(ssr): wait for context.rendered (fix #11256) Mar 31, 2020
@eunjae-lee eunjae-lee closed this Mar 11, 2021
@eunjae-lee eunjae-lee deleted the ssr-async-context-rendered branch March 11, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vue-server-renderer] support for context.rendered which returns a promise
1 participant