Skip to content

fix(compiler-sfc): fix rewriteDefault problem when using @babel/parser@^7.20.0 #12906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(compiler-sfc): fix rewriteDefault problem when using @babel/parser@^7.20.0 #12906

wants to merge 1 commit into from

Conversation

linshuohao
Copy link
Contributor

close #12892

babel/babel#15032 change the location of the export declaration when use decorators before export

@linshuohao linshuohao mentioned this pull request Dec 19, 2022
Closed
@linshuohao linshuohao force-pushed the fix-compiler-sfc branch 10 times, most recently from 4f8103c to 4e2a327 Compare December 21, 2022 08:26
@yyx990803 yyx990803 closed this in 25f97a5 Dec 6, 2023
@yyx990803
Copy link
Member

Thanks for the PR, but the lockfile updates are a bit difficult to resolve directly from your branch.

landed separately in 10c2a87 and 25f97a5 (which also uses the exact same logic from Vue 3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.7.14][class component][sfc][vite] Method names containing "export" and "default" break lifecycle hooks
2 participants
@linshuohao @yyx990803