Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lifecycle): scope might changed when call hook #13070

Merged
merged 2 commits into from Oct 22, 2023

Conversation

gcaaa31928
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This pull request's issue originates from a specific problem mentioned in vuejs/pinia#1800 . Due to the potential for callHook to modify the upper-level scope's behavior of collecting effects, it subsequently leads to incorrect effects being torn down when stopping in the wrong scope.

@gcaaa31928 gcaaa31928 force-pushed the i/fix-scope-changed-when-call-hook branch from f40e9dc to 116c21d Compare August 23, 2023 17:59
@joeRinehart
Copy link

This'd be great to have reviewed and merged. We're in the middle of moving a fairly large Vue 2 + Vuex application into Pinia, and we'd like to avoid the boilerplate in working around this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants