Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition group with dynamic name not correctly applying transition #6006

Closed
mcmillenb opened this issue Jun 30, 2017 · 1 comment · Fixed by #6019
Closed

Transition group with dynamic name not correctly applying transition #6006

mcmillenb opened this issue Jun 30, 2017 · 1 comment · Fixed by #6019
Labels

Comments

@mcmillenb
Copy link
Contributor

Version

2.3.0

Reproduction link

https://jsfiddle.net/oyf86mcp/

Steps to reproduce

  1. Run the fiddle
  2. Uncheck the checkbox
  3. Click "Shuffle" button
  4. Check the checkbox
  5. Click "Shuffle" button

What is expected?

After first "Shuffle" click (with an unchecked checkbox), list items are reordered with no transition animation.

After second "Shuffle" click (with a checked checkbox), list items are reordered with a transition animation.

What is actually happening?

After first "Shuffle" click (with an unchecked checkbox), list items are reordered with no transition animation.

After second "Shuffle" click (with a checked checkbox), list items are still reordered with no transition animation.


Found via this question on StackOverflow:
https://stackoverflow.com/questions/44850588/disable-transition-animation/44851948#44851948

If the list is shuffled before initially unchecking the checkbox, everything works as expected. I'm only seeing this when the list is initially shuffled when the name of the transition group is set to "disabled-list".

@posva
Copy link
Member

posva commented Jul 2, 2017

Thanks for reporting it! This shouldn't be happening indeed. I didn't dig further but you can workaround it for the moment by specifying a :key="transitionName" on the transition-group element

@posva posva added the bug label Jul 2, 2017
Kingwl pushed a commit to Kingwl/vue that referenced this issue Jul 3, 2017
yyx990803 pushed a commit that referenced this issue Jul 5, 2017
* fix: transition group should work with dynamic name (#6006)

* fix: improve remove class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants