feat(warnings): Suggest casting boolean keys #6127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
force-pushed
the
feat/warning-key-bool
branch
from
5193b78
to
4940941
Compare
|
Let's just support boolean keys, it's not best practice but it should work if the user know what they're doing. |
posva
force-pushed
the
feat/warning-key-bool
branch
from
4940941
to
7f277c7
Compare
posva
force-pushed
the
feat/warning-key-bool
branch
from
7f277c7
to
0f7f8d9
Compare
|
I added the check to |
yyx990803
pushed a commit
that referenced
this pull request
Jul 19, 2017
suppresses key warning for boolean values, closes #6126
mpawelski
added a commit
to mpawelski/vue
that referenced
this pull request
Jun 4, 2020
Booleans as keys are supported since vuejs#6127 and symbols since vuejs#7271. The warning should reflect that.
mpawelski
added a commit
to mpawelski/vue
that referenced
this pull request
Jun 4, 2020
Booleans as keys are supported since vuejs#6127 and symbols since vuejs#7271. The warning should reflect that.
mpawelski
added a commit
to mpawelski/vue
that referenced
this pull request
Jun 4, 2020
Booleans as keys are supported since vuejs#6127 and symbols since vuejs#7271. The warning should reflect that.
13 tasks
mpawelski
added a commit
to mpawelski/vue
that referenced
this pull request
Jun 4, 2020
Booleans as keys are supported since vuejs#6127 and symbols since vuejs#7271. The warning should reflect that.
mpawelski
added a commit
to mpawelski/vue
that referenced
this pull request
Jun 4, 2020
Booleans as keys are supported since vuejs#6127 and symbols since vuejs#7271. The warning should reflect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6126
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: