Add slot v-bind warning (fix #6677) #6736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-bind with not object warning 6677
posva
requested changes
Oct 4, 2017
| @@ -15,6 +15,12 @@ export function renderSlot ( | |||
| if (scopedSlotFn) { // scoped slot | |||
| props = props || {} | |||
| if (bindObject) { | |||
| if (!isObject(bindObject)) { | |||
| process.env.NODE_ENV !== 'production' && warn( | |||
There was a problem hiding this comment.
can you move the process.env.NODE_ENV !== 'production' into the if condition so it gets stripped off in production mode?
There was a problem hiding this comment.
Oh, of course I can move it!
Sure, I will add the test.
|
Ready to merge :) |
ztlevi
pushed a commit
to ztlevi/vue
that referenced
this pull request
Feb 14, 2018
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v-bind with not object warning
close #6677
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: