feat(core): support KeyboardEvent.key for built in keyboard event modifiers, fix #6900 #7121
Conversation
src/compiler/codegen/events.js
Outdated
| @@ -16,6 +16,18 @@ const keyCodes: { [key: string]: number | Array<number> } = { | |||
| 'delete': [8, 46] | |||
| } | |||
|
|
|||
| const keyNames: { [key: string]: string | Array<string> } = { | |||
There was a problem hiding this comment.
Why not just move the keyNames and keyCodes to runtime instead of in the compiler? Since it leads sooo much repetition and should reduce the code size.
There was a problem hiding this comment.
Actually in my first version, I did define keyNames in check-keycodes.js. After that I realize this would increase much runtime bundle size, so I got it moved into compiler...
There was a problem hiding this comment.
I guess the reason keyCodes stays in compiler is that it simply generate numbers rather strings. Agreed for moving keyNames into runtime.🙂
There was a problem hiding this comment.
Ya, considering all compiled templates size together, it could reasonable to move them into runtime. BTW, seems it has not that much different to deal with keyCodes and keyNames.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
#6900