Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): bump ts version and fix typing bugs #7135

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

HerringtonDarkholme
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

Other information:

Component is too restrictive about props type: it either accepts an array or an object, but not both. This makes it illegal to assign CompoenntOptions to Component. Actually it is a typing bug, but it requires TS 2.6 to find this out.

So this pull request also bumps the compiler version. It only affects development.
Bumping version also finds another method naming problem in directive test :)

cc @ktsn

Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants