fix(types): bump ts version and fix typing bugs #7135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
13 tasks
lovelope
pushed a commit
to lovelope/vue
that referenced
this pull request
Feb 1, 2018
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
aJean
pushed a commit
to aJean/vue
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)Other information:
Componentis too restrictive aboutpropstype: it either accepts an array or an object, but not both. This makes it illegal to assignCompoenntOptionstoComponent. Actually it is a typing bug, but it requires TS 2.6 to find this out.So this pull request also bumps the compiler version. It only affects development.
Bumping version also finds another method naming problem in directive test :)
cc @ktsn