Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): support filters with () in older browsers #7545

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

posva
Copy link
Member

@posva posva commented Jan 27, 2018

Fix #7544
Make sure no extra , is added at the end of the call so it also work with older browsers

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Fix vuejs#7544
Make sure no extra , is added at the end of the call so it also work with older browsers
@posva posva requested a review from yyx990803 January 27, 2018 15:23
@posva
Copy link
Member Author

posva commented Feb 20, 2018

ping @yyx990803

@yyx990803 yyx990803 merged commit dc97a39 into vuejs:dev Mar 8, 2018
@posva posva deleted the fix/no-args-filters branch March 8, 2018 16:28
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
Fix vuejs#7544
Make sure no extra , is added at the end of the call so it also work with older browsers
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Fix vuejs#7544
Make sure no extra , is added at the end of the call so it also work with older browsers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filter with empty arguments cause error in chrome 57-
2 participants