Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing asyncMeta during VNode cloning #7861

Merged
merged 2 commits into from
Mar 23, 2018
Merged

Conversation

luisatmaniak
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix

Does this PR introduce a breaking change? (check one)

  • No

The PR fulfills these requirements:

Other information:
This fixes a crash during SSR, where a parent functional component is using an async component in the render function. If the prop is not copied, renderAsyncComponent crashes during rendering. Looks like this bug was introduced in 62a922e

@yyx990803
Copy link
Member

Thanks for the fix, is it possible to provide a reproduction for the case so we can better determine if this fix is sufficient?

@yyx990803 yyx990803 merged commit 8227fb3 into vuejs:dev Mar 23, 2018
@yyx990803
Copy link
Member

I merged it because asyncMeta indeed should be copied, but if possible, I'd still love to see a reproduction of the case so that we can be sure this fix covers the bug properly. Thanks.

f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants