Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): support IE11 and Edge use of "Esc" key (close #7880) #7887

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

matheusazzi
Copy link
Contributor

@matheusazzi matheusazzi commented Mar 23, 2018

Closes #7880

IE11 and Edge use "Esc" as key name, other browsers use "Escape".

I was able to test on Edge 16/15/14 and IE11.

screenshot 2018-03-23 13 05 45

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@yyx990803 yyx990803 merged commit 1bd6196 into vuejs:dev Mar 23, 2018
akbarmdmd pushed a commit to akbarmdmd/vue that referenced this pull request Nov 23, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@keydown.escape does not work in Edge
3 participants