Need judge styles[transitionProp 'Duration'] is undefined (fix #7444) #8281

industral · 2018-05-30T20:07:51Z

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

Yes
No

The PR fulfills these requirements:

It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
New/updated tests are included

Other information:

jsdom returns undefined from style instead of empty string.

$ node
> const jsdom = require("jsdom");
undefined
> const { JSDOM } = jsdom;
undefined
> const dom = new JSDOM(`<!DOCTYPE html><p style="color: red;">Hello world</p>`);
undefined
> dom.window.document.querySelector("p").style
CSSStyleDeclaration {
  '0': 'color',
  _values: { color: 'red' },
  _importants: { color: '' },
  _length: 1,
  _onChange: [Function] }
> dom.window.document.querySelector("p").style.color
'red'
> dom.window.document.querySelector("p").style.unexisted
undefined
>

So a solution is to do like that:

(styles[transitionProp + 'Delay'] || '').split(', ')

adin234 · 2018-07-09T11:34:42Z

+1

romap0 · 2018-07-21T22:10:25Z

Any news on it?

adin234 · 2018-09-11T16:44:12Z

still nothing?

adin234 · 2018-10-23T16:57:47Z

WAOOOOOW

…js#8281)

fixed vuejs#7444

0d95627

industral mentioned this pull request Jul 9, 2018

[Bug Report] Run unit test issue: when I run unit test, it shows: Cannot read property 'split' of undefined ElemeFE/element#9279

Closed

Update transition-util.js

d38cfec

yyx990803 added the ready to merge label Oct 23, 2018

yyx990803 merged commit 5cfdf1a into vuejs:dev Oct 24, 2018

f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019

fix: handle undefined style properties in jsdom (fix vuejs#7444) (vue…

f75fdd5

…js#8281)

aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020

fix: handle undefined style properties in jsdom (fix vuejs#7444) (vue…

edfd04a

…js#8281)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Need judge styles[transitionProp 'Duration'] is undefined (fix #7444) #8281

Need judge styles[transitionProp 'Duration'] is undefined (fix #7444) #8281

industral commented May 30, 2018 •

edited

Loading

adin234 commented Jul 9, 2018

romap0 commented Jul 21, 2018

adin234 commented Sep 11, 2018

adin234 commented Oct 23, 2018

Need judge styles[transitionProp 'Duration'] is undefined (fix #7444) #8281

Need judge styles[transitionProp 'Duration'] is undefined (fix #7444) #8281

Conversation

industral commented May 30, 2018 • edited Loading

adin234 commented Jul 9, 2018

romap0 commented Jul 21, 2018

adin234 commented Sep 11, 2018

adin234 commented Oct 23, 2018

industral commented May 30, 2018 •

edited

Loading