feat: Store functional render context on vnode in development #8586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvfritz
reviewed
Aug 2, 2018
| // #7817 clone node before setting fnContext, otherwise if the node is reused | ||
| // (e.g. it was from a cached normal slot) the fnContext causes named slots | ||
| // that should not be matched to match. | ||
| const clone = cloneVNode(vnode) | ||
| clone.fnContext = contextVm | ||
| clone.fnOptions = options | ||
| if (process.env.NODE_ENV !== 'production') { | ||
| clone.devtoolsMeta = renderContext |
There was a problem hiding this comment.
Should we make devtoolsMeta an object with a renderContext property instead? For example:
clone.devtoolsMeta = { renderContext }I'm thinking it might be easier to add other information to devtoolsMeta later this way.
eddyerburgh
approved these changes
Aug 4, 2018
|
Should we also add a test for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used in vuejs/devtools-v6#719 to display prop values in component inspector.