Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing keyup to keypress to properly deal transform of Japanese chars #9172

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Changing keyup to keypress to properly deal transform of Japanese chars #9172

merged 1 commit into from
Dec 11, 2018

Conversation

FumioNonaka
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
[TodoMVC Example] [enter] key event to determin transform of Japanese characters makes the item added to list

@kazupon
Copy link
Member

kazupon commented Dec 11, 2018

Thank you for your PR!

I think that you should be fix the jsfiddle example.
https://vuejs.org/v2/examples/todomvc.html

@yyx990803 yyx990803 merged commit 6980035 into vuejs:dev Dec 11, 2018
yyx990803 added a commit that referenced this pull request Dec 11, 2018
@FumioNonaka
Copy link
Contributor Author

How could I edit the source of the jsfiddle example? I folked and fixed it as follows:
"Vue.js: TodoMVC revised"

f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
@ubershmekel
Copy link

Seems this was reverted. I wonder why. I haven't tested it either way. But I also didn't find docs describing the difference between keypress and keyup in vue.

aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants