add sync modifier with bind object #5943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
reviewed
Jun 21, 2017
src/compiler/parser/index.js
Outdated
| } else { | ||
| // bind update event for sync modifier and bind object | ||
| if (modifiers && modifiers.sync && name === 'v-bind') { | ||
| addSyncUpdateHandler(el, value, value) |
There was a problem hiding this comment.
I think it's a bit more complicated than that as we need to add a handler for every property in the v-bind object but I haven't researched much.
Also, imagine the case where value is directly an object: { foo, bar }, we really want to add update:foo and update:bar
Kingwl
force-pushed
the
dev-sync-bind-object
branch
from
540b7b9
to
9489c4a
Compare
Kingwl
force-pushed
the
dev-sync-bind-object
branch
from
9489c4a
to
4cdcc8c
Compare
Kingwl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
#5937