Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style does not work with zIndex (fix #9382) #9386

Merged
merged 1 commit into from Jan 31, 2019

Conversation

@Itisfilipe
Copy link
Contributor

commented Jan 29, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
The documentation states that the first parameter for setProperty must be hyphenated.

closes #9382

src/platforms/web/runtime/modules/style.js Outdated Show resolved Hide resolved
fix(style): Fix property name case for setProperty
From the documentation (MDN) style.setProperty must have its property name as hyphen case

@Itisfilipe Itisfilipe force-pushed the Itisfilipe:issue_9382 branch from 5e78d61 to d801465 Jan 29, 2019

@yyx990803 yyx990803 merged commit 539e481 into vuejs:dev Jan 31, 2019

4 of 5 checks passed

ci/circleci: test-ssr-weex Your tests failed on CircleCI
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types Your tests passed on CircleCI!
Details
ci/circleci: test-cover Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.