fix: pass a default options to bind*

Author: posva

packages/@posva/vuefire-core/src/index.js

@@ -59,7 +59,10 @@ function subscribeToRefs({ subs, refs, target, path, data, depth, ops, resolve }
   })
 }
 
-export function bindCollection({ vm, key, collection, ops, resolve, reject }, options) {
+export function bindCollection(
+  { vm, key, collection, ops, resolve, reject },
+  options = { maxRefDepth: 2 }
+) {
   // TODO support pathes? nested.obj.list (walkSet)
   // NOTE use ops object
   const array = ops.set(vm, key, [])
@@ -170,7 +173,7 @@ export function bindCollection({ vm, key, collection, ops, resolve, reject }, op
 
 function updateDataFromDocumentSnapshot(
   { snapshot, target, path, subs, ops, depth = 0, resolve },
-  options
+  options = { maxRefDepth: 2 }
 ) {
   const [data, refs] = extractRefs(snapshot, walkGet(target, path))
   // NOTE use ops

packages/@posva/vuefire-core/test/collection.spec.js

@@ -115,4 +115,14 @@ describe('collections', () => {
     ).rejects.toThrow()
     collection.onSnapshot.mockRestore()
   })
+
+  it('resolves when the collection is populated', async () => {
+    await collection.add({ foo: 'foo' })
+    await collection.add({ foo: 'foo' })
+    const promise = new Promise((resolve, reject) => {
+      bindCollection({ vm, collection, key: 'items', resolve, reject, ops })
+    })
+    await promise
+    expect(vm.items).toEqual([{ foo: 'foo' }, { foo: 'foo' }])
+  })
 })

packages/@posva/vuefire-core/test/document.spec.js

@@ -80,4 +80,13 @@ describe('documents', () => {
     ).rejects.toThrow()
     document.onSnapshot.mockRestore()
   })
+
+  it('resolves when the document is set', async () => {
+    await document.update({ foo: 'foo' })
+    const promise = new Promise((resolve, reject) => {
+      bindDocument({ vm, document, key: 'item', resolve, reject, ops })
+    })
+    await promise
+    expect(vm.item).toEqual({ foo: 'foo' })
+  })
 })