Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar group item cannot contain empty children #1278

Closed
1 task done
Armaldio opened this issue Feb 11, 2019 · 1 comment
Closed
1 task done

Sidebar group item cannot contain empty children #1278

Armaldio opened this issue Feb 11, 2019 · 1 comment
Labels
type: bug Something isn't working

Comments

@Armaldio
Copy link

  • I confirm that this is a issue rather than a question.

Bug report

Version

vuepress: ^1.0.0-alpha.37

Steps to reproduce

yarn dev

What is expected?

The project should build and display the page.
Groups with empty childrens should only show the title as of vuepress@0.x

What is actually happening?

The build is successfull but the page is blank it an error is shown in the developer console
image

Other relevant information

  • Your OS: Windows 10
  • Node.js version: v10.15.0
  • Browser version: Chrome 72
  • Is this a global or local install? > Locale
  • Which package manager did you use for the install? > yarn
sidebar: [
      {
        title: '1',
        children: [
          ['/intro/', 'Introduction'],
        ],
      },
      {
        title: '2',
        children: [],
      },
    }
}
@ulivz ulivz closed this as completed in 5f1eb0e Feb 13, 2019
@ulivz
Copy link
Member

ulivz commented Feb 13, 2019

Thanks for the report, this is a regression bug of 11ce576

Since a sidebar group item can also have a path item from 1.0-alpha.36, so VuePress will intentionally convert the empty sidebar group item to a page item so that the headers of that page can be shown.

@ulivz ulivz added the type: bug Something isn't working label Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants