-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix($theme-default): Expand nested sidebar groups #1540
fix($theme-default): Expand nested sidebar groups #1540
Conversation
6d183ff
to
290142a
Compare
Thanks for your work @timaschew. Can you add some test to validate what you mean please |
@f3ltron are you talking about to write a test case (code) or about a demo to show? Later can be viewed here: |
Oh ok i definitely see the improvment now ^^. Just let me some time to review it and i will speak with the others about it. You can start by adding / updating the doc part about it |
What do you mean? This is a bug for me so I wouldn't assume it require to change any documentation. |
I will have a look about it. It's look it was actually not supported by Vuepress. Thank's for the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timaschew Thanks for this PR 💪 Could you just accept my code suggestions to improve code readability
Co-Authored-By: Franck Abgrall <abgrallkefran@gmail.com>
Co-Authored-By: Franck Abgrall <abgrallkefran@gmail.com>
Co-Authored-By: Franck Abgrall <abgrallkefran@gmail.com>
Co-Authored-By: Franck Abgrall <abgrallkefran@gmail.com>
Hi @kefranabg thanks for the code review! Sure I've confirmed your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks @timaschew
Hey @timaschew, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Currently only direct children of a groups are checked (if any of them is active).
This fix checks the children recursively.
Fix #1497
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: