-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat($theme-default): enable editLink on specific page via frontmatter (close: #1762) (#1825) #1825
Conversation
Thanks for this PR. I’ll do a review ASAP. |
@pniedzwiedzinski Could you revert changes related to the code formatting? It would remove unnecessary changes and would be easier to understand what is really related to the feature 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since "lodash/isNil"
is not a explicitly declared dependency in VuePress, you need to add it by yourself.
BTW, the title of a pull request should be given so we can know what problems it solves, Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! Could you add lodash
in the theme-default
package dependencies and solve the conflict?
@pniedzwiedzinski Is that ok for you to solve the conflict? If you're not comfortable with it I'll do it. |
Better if you do that, thanks! |
Hey @pniedzwiedzinski, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
When I'm reading the changelog, I found that this pull request doesn't match the commit message convention, and even took a misleading information. Since it's actually a feature request instead of a bug fixes, we need to modify the prefix from So the final commit message should be:
Comparing to the actual commit:
|
Summary
This PR closes #1762
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: