Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak: make the SearchBox of default theme better in narrow screen #254

Merged
merged 1 commit into from
Apr 25, 2018
Merged

tweak: make the SearchBox of default theme better in narrow screen #254

merged 1 commit into from
Apr 25, 2018

Conversation

meteorlxy
Copy link
Member

  • cursor on search box should be pointer when it is not focused in narrow screen (only the icon is displayed)
  • when the screen width is between $MQNarrow and $MQMobile, the .suggestions box may overflow the left edge

@ulivz
Copy link
Member

ulivz commented Apr 25, 2018 •
edited
Loading

Thanks for this work, but it would be better to provide the contrastive snapshots when doing any UI change:

Before

image

After

image

@ulivz ulivz merged commit 8f04081 into vuejs:master Apr 25, 2018
@meteorlxy
Copy link
Member Author

Got it~ Thanks~

@meteorlxy meteorlxy deleted the patch-1 branch April 26, 2018 03:34
@ulivz ulivz mentioned this pull request May 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteorlxy @ulivz