Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added escaping of meta tag attribute value #29

Merged
merged 2 commits into from
Apr 15, 2018
Merged

Added escaping of meta tag attribute value #29

merged 2 commits into from
Apr 15, 2018

Conversation

jakub-swierk
Copy link
Contributor

Bug: Any occurence of quotation mark causes invaild html being rendered:

example.md

meta:
- foo: how to "broke" bar

before patch:

<meta foo="how to "broke" bar">

after patch:

<meta foo="how to &quot;broke&quot; bar">

ulivz
ulivz approved these changes Apr 14, 2018
View reviewed changes
Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yyx990803 yyx990803 merged commit 15a1ac8 into vuejs:master Apr 15, 2018
meteorlxy added a commit that referenced this pull request Jun 17, 2021
@meteorlxy
feat(theme-default): support dark mode (close #29)
680e429 
BREAKING CHANGE: most sass variables are migrated to css variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulivz ulivz ulivz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakub-swierk @ulivz @yyx990803