-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: code line number (close: #365) #379
Conversation
I think it would be nicer to make this a separate markdown-it plugin. Semantically it is not right to put this feature in highlightLines plugin. P.S. I am working on the same thing too but haven't yet complete it. |
Also, the current implementation make the line number selectable? Which might not be ideal? |
Sure, I originally want to make it as a separate plugin, but since
Agree, but the better choice is to rename this plugin to
Have handled for that. |
@ulivz Unbelievable. That's what I want. |
cc @egoist , it also fixed a empty line highlight issue:
`<span class="highlighted-line">${split || '\n'}</span>`
Snapshot
Highlight line + Line number
Only line number
Only Highlight line