fix: highlight lines are cut when sliding #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This issue was introduced by fixing #350 at d0ef06f, and due to
<span> in <code> cannot expand to 100% width of <code>.Since we have hoisted
pre-wrapperas a standalone plugin at 45a3df5, we can also hoist the highlight lines element as an adjacent element to<pre>and create new stacking context to implement the same function.BTW, the advantage of this PR is that we can avoid modifying the code in
<pre><code>directly.Before (Actual Behaviors)
After (Expected Behaviors)