Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple markdown tokens regexp #564

Merged
merged 2 commits into from
Jun 20, 2018
Merged

Conversation

halaaro
Copy link
Contributor

@halaaro halaaro commented Jun 10, 2018

Summary

Fixes issue for bold and italic text in headers as well as multiple sets of tokens

# `keyword1` and `keyword2`
# ***bold and italic***
# **bold** and *italic*

Currently, only the one set of tokens is removed from the table of contents and sidebar links:

screen shot 2018-06-09 at 9 56 41 pm

Change makes the regexp non-greedy for matching the token pairs (*?) and matches up to 3 pairs of asterisks (\*{1,3}).

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

N/A

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@halaaro
Copy link
Contributor Author

halaaro commented Jun 10, 2018

@ulivz not sure how to proceed as this is my first PR, but please review this fix when you get a chance

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ulivz ulivz merged commit ec330f0 into vuejs:master Jun 20, 2018
@halaaro halaaro deleted the header-token-fixes branch June 21, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants