Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize override file path in windows (#692) (close: #642) #692

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

jingzhe
Copy link
Contributor

@jingzhe jingzhe commented Aug 1, 2018

Fix escape characters in windows, such as "\n" (close: #642)

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@ulivz ulivz changed the title Fix Issue #642, fix escape character in windows fix: normalize override file path in windows (#692) (close: #642) Aug 1, 2018
@ulivz ulivz merged commit 9537c2c into vuejs:master Aug 1, 2018
@ulivz
Copy link
Member

ulivz commented Aug 1, 2018

Released it in a patch (0.13.1), you can try it by upgrading your vuepress.

@jingzhe
Copy link
Contributor Author

jingzhe commented Aug 2, 2018

new version 0.13.1 works perfectly. Thanks.

@ulivz ulivz mentioned this pull request Sep 28, 2018
18 tasks
@NonPolynomial
Copy link
Contributor

NonPolynomial commented Dec 30, 2018

This have also to be done in the 1.x.x versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vuepress project cannot be in some folder name start with n
3 participants